Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A83E411A17 for ; Wed, 9 Jul 2014 21:11:09 +0000 (UTC) Received: (qmail 60507 invoked by uid 500); 9 Jul 2014 21:11:06 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 60171 invoked by uid 500); 9 Jul 2014 21:11:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 60037 invoked by uid 99); 9 Jul 2014 21:11:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jul 2014 21:11:06 +0000 Date: Wed, 9 Jul 2014 21:11:06 +0000 (UTC) From: "Gaurav Menghani (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (HBASE-11257) [0.89-fb] Remove the timestamp from the annotation of Put MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaurav Menghani resolved HBASE-11257. ------------------------------------- Resolution: Fixed Release Note: This was completed. > [0.89-fb] Remove the timestamp from the annotation of Put > --------------------------------------------------------- > > Key: HBASE-11257 > URL: https://issues.apache.org/jira/browse/HBASE-11257 > Project: HBase > Issue Type: Improvement > Reporter: Gaurav Menghani > Assignee: Gaurav Menghani > Priority: Minor > > David and I, recently found out, when discussing the C++ client with @csliu from the Search Team, that we have an extraneous timestamp field in the Put. Actually, that field is used when we create a Put object like: > Put p = new Put(row, ts); > And then, if you do: > p.add(cf, qualifier, value); > it would use ts as a timestamp for the KeyValue for the cf, qualifier. If you did not specify it, it will use HConstants.LATEST_TIMESTAMP. > One can also do this, where you explicitly state the timestamp to be used: > p.add(cf, qualifier, ts, value) > In either case, when the add() method is called, the KeyValue is constructed, and it has the proper timestamp. Therefore, once you have created the family map with all these KeyValues, you don't need to send the ts field provided during the construction. All the KVs will have the correct timestamp embedded by the time it will be sent across. > This diff removes the timestamp field from the Put object. This will save us some network bandwidth, hopefully :) -- This message was sent by Atlassian JIRA (v6.2#6252)