Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 15 Jul 2014 09:33:05 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12710220.1398315485913.43612.1405416785226@arcas>
In-Reply-To: <JIRA.12710220.1398315485913@arcas>
References: <JIRA.12710220.1398315485913@arcas>
Subject: [jira] [Commented] (HBASE-11064) Odd behaviors of TableName for
 empty namespace
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061879#comment-14061879 ] 

Hadoop QA commented on HBASE-11064:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12655727/HBASE-11064.2.patch
  against trunk revision .
  ATTACHMENT ID: 12655727

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10068//console

This message is automatically generated.

> Odd behaviors of TableName for empty namespace
> ----------------------------------------------
>
>                 Key: HBASE-11064
>                 URL: https://issues.apache.org/jira/browse/HBASE-11064
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.3
>            Reporter: Hiroshi Ikeda
>            Assignee: Rekha Joshi
>            Priority: Trivial
>             Fix For: 0.99.0, 1.0.0, 0.98.5
>
>         Attachments: HBASE-11064.1.patch, HBASE-11064.2.patch
>
>
> In the class TableName,
> {code}
> public static byte [] isLegalFullyQualifiedTableName(final byte[] tableName) {
> ...
> int namespaceDelimIndex = ...
> if (namespaceDelimIndex == 0 || namespaceDelimIndex == -1){
>   isLegalTableQualifierName(tableName);
> } else {
> ...
> {code}
> That means, for example, giving ":a" as the argument throws an exception which says invalid qualifier, instead of invalid namespace.
> Also, TableName.valueOf(String) and valueOf(byte[]) can create an instance with empty namespace, which is inconsistent.


--
This message was sent by Atlassian JIRA
(v6.2#6252)