hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11630) Refactor TestAdmin to use Admin interface instead of HBaseAdmin
Date Thu, 31 Jul 2014 16:46:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081096#comment-14081096
] 

stack commented on HBASE-11630:
-------------------------------

[~carterpage] lgtm I can add comment on why an HBaseAdmin instance (rather than use the Admin
interface) on commit.  Waiting on hadoopqa (though it has been a bit flakey of late)

> Refactor TestAdmin to use Admin interface instead of HBaseAdmin
> ---------------------------------------------------------------
>
>                 Key: HBASE-11630
>                 URL: https://issues.apache.org/jira/browse/HBASE-11630
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.99.0
>            Reporter: Carter
>            Assignee: Carter
>             Fix For: 0.99.0
>
>         Attachments: HBASE_11630-branch-1.patch
>
>
> I'm starting to refactor some of the code to start calling against interfaces.
> TestAdmin is fairly straightforward except for #testGetRegion, since it is testing an
internal method.  Disregarding whether that makes sense for a unit test, I punted and created
a copy of the underlying HBaseAdmin object for that one method.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message