hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-11586) HFile's HDFS op latency sampling code is not used
Date Fri, 25 Jul 2014 05:16:38 GMT

     [ https://issues.apache.org/jira/browse/HBASE-11586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Purtell updated HBASE-11586:
-----------------------------------

    Description: 
HFileReaderV2 calls HFile#offerReadLatency and HFileWriterV2 calls HFile#offerWriteLatency
but the samples are never retrieved. There are no callers of HFile#getReadLatenciesNanos,
HFile#getWriteLatenciesNanos, and related. The three ArrayBlockingQueues we are using as sample
buffers in HFile will fill quickly and are never drained. 

There are also no callers of HFile#getReadTimeMs or HFile#getWriteTimeMs, and related, so
we are incrementing a set of AtomicLong counters that will never be read nor reset.

We are calling System.nanoTime in block read and write paths twice but not utilizing the measurements.

We should hook this code back up to metrics or remove it.

We are also not using HFile#getChecksumFailuresCount anywhere but in some unit test code.

  was:
HFileReaderV2 calls HFile#offerReadLatency and HFileWriterV2 calls HFile#offerWriteLatency
but the samples are never drained. There are no callers of HFile#getReadLatenciesNanos, HFile#getWriteLatenciesNanos,
and related. The three ArrayBlockingQueues we are using as sample buffers in HFile will fill
quickly and are never drained. 

There are also no callers of HFile#getReadTimeMs or HFile#getWriteTimeMs, and related, so
we are incrementing a set of AtomicLong counters that will never be read nor reset.

We are calling System.nanoTime in block read and write paths twice but not utilizing the measurements.

We should hook this code back up to metrics or remove it.

We are also not using HFile#getChecksumFailuresCount anywhere but in some unit test code.


> HFile's HDFS op latency sampling code is not used
> -------------------------------------------------
>
>                 Key: HBASE-11586
>                 URL: https://issues.apache.org/jira/browse/HBASE-11586
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.4
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.99.0, 0.98.5, 2.0.0
>
>         Attachments: HBASE-11586.patch, HBASE-11586.patch
>
>
> HFileReaderV2 calls HFile#offerReadLatency and HFileWriterV2 calls HFile#offerWriteLatency
but the samples are never retrieved. There are no callers of HFile#getReadLatenciesNanos,
HFile#getWriteLatenciesNanos, and related. The three ArrayBlockingQueues we are using as sample
buffers in HFile will fill quickly and are never drained. 
> There are also no callers of HFile#getReadTimeMs or HFile#getWriteTimeMs, and related,
so we are incrementing a set of AtomicLong counters that will never be read nor reset.
> We are calling System.nanoTime in block read and write paths twice but not utilizing
the measurements.
> We should hook this code back up to metrics or remove it.
> We are also not using HFile#getChecksumFailuresCount anywhere but in some unit test code.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message