hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11573) Report age on eviction
Date Wed, 23 Jul 2014 06:30:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071412#comment-14071412
] 

Hadoop QA commented on HBASE-11573:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12657284/11573v7.txt
  against trunk revision .
  ATTACHMENT ID: 12657284

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 9 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +            <& bc_l; bc = bcs == null? null: bcs.length <= 1? null: bcs[1];
name = "L2"; evictions = evictions; &>
+        <td><% String.format("%,d", (long)(ageAtEvictionSnapshot.getMean()/(1000000
* 1000))) %></td>
+<p><b>Too many blocks!</b> Listing out the first <% cbsbfSnapshot.getMax()
%> only (hbase.ui.blockcache.by.file.max)</p> 
+<%if bcv.equals("file") %><& bc_by_file; cbsbf = cbsbf; &><%else>[
<% BlockCacheUtil.toJSON(bc) %>, <% BlockCacheUtil.toJSON(cbsbf) %> ]</%if>

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.io.hfile.TestLruBlockCache

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10156//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10156//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10156//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10156//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10156//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10156//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10156//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10156//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10156//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10156//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10156//console

This message is automatically generated.

> Report age on eviction
> ----------------------
>
>                 Key: HBASE-11573
>                 URL: https://issues.apache.org/jira/browse/HBASE-11573
>             Project: HBase
>          Issue Type: Sub-task
>          Components: BlockCache
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.99.0, 2.0.0
>
>         Attachments: 11573.txt, 11573v2.txt, 11573v3.txt, 11573v4.txt, 11573v5.txt, 11573v7.txt,
Screen Shot 2014-07-22 at 5.17.27 PM.png
>
>
> From the parent issue, Todd reminds us of the old Jim Gray '5 minute rule' on whether
to cache.
> In master, we were reporting age only it was the inactionable inverse of 'how long blocks
are staying in the cache'.
> Let me add to our cache stats a histogram of age on eviction and change the UI reporting
so it is age at eviction (plus stddev).  The JSON version has percentiles (and if wanted,
the old age report of age of items in cache).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message