hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11551) BucketCache$WriterThread.run() doesn't handle exceptions correctly
Date Wed, 23 Jul 2014 14:32:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071780#comment-14071780
] 

stack commented on HBASE-11551:
-------------------------------

bq. The above exception ‘Failed allocating for block bck2_0’ won't cause writerThread
exiting.

So, the issue is your observation [~zjushch] but [~ted_yu] files it and adds the patch?  Then
[~ted_yu] posts justification for the patch but the patch does not address the justification?

[~ted_yu] where does the posted exception come from?  We should fix it.

> BucketCache$WriterThread.run() doesn't handle exceptions correctly
> ------------------------------------------------------------------
>
>                 Key: HBASE-11551
>                 URL: https://issues.apache.org/jira/browse/HBASE-11551
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 11551-v1.txt
>
>
> Currently the catch is outside the while loop:
> {code}
>       try {
>         while (cacheEnabled && writerEnabled) {
> ...
>       } catch (Throwable t) {
>         LOG.warn("Failed doing drain", t);
>       }
> {code}
> When exception (e.g. BucketAllocatorException) is thrown, run() method would terminate,
silently.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message