hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11551) BucketCache$WriterThread.run() doesn't handle exceptions correctly
Date Wed, 23 Jul 2014 04:09:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071339#comment-14071339
] 

Ted Yu commented on HBASE-11551:
--------------------------------

Here was the stack trace for BucketAllocatorException bubbling out of the run() method:
{code}
2014-07-19 21:13:28,581 WARN  [Thread-1-BucketCacheWriter-0] bucket.BucketCache$WriterThread(736):
Failed allocating for block bck2_0
org.apache.hadoop.hbase.io.hfile.bucket.BucketAllocatorException: Allocation too big size=3779687
  at org.apache.hadoop.hbase.io.hfile.bucket.BucketAllocator.allocateBlock(BucketAllocator.java:418)
  at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache$RAMQueueEntry.writeToCache(BucketCache.java:1159)
  at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache$WriterThread.doDrain(BucketCache.java:728)
  at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache$WriterThread.run(BucketCache.java:700)
  at java.lang.Thread.run(Thread.java:745)
{code}

> BucketCache$WriterThread.run() doesn't handle exceptions correctly
> ------------------------------------------------------------------
>
>                 Key: HBASE-11551
>                 URL: https://issues.apache.org/jira/browse/HBASE-11551
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.99.0, 2.0.0
>
>         Attachments: 11551-v1.txt
>
>
> Currently the catch is outside the while loop:
> {code}
>       try {
>         while (cacheEnabled && writerEnabled) {
> ...
>       } catch (Throwable t) {
>         LOG.warn("Failed doing drain", t);
>       }
> {code}
> When exception (e.g. BucketAllocatorException) is thrown, run() method would terminate,
silently.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message