hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11551) BucketCache$WriterThread.run() doesn't handle exceptions correctly
Date Wed, 23 Jul 2014 03:30:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071320#comment-14071320
] 

stack commented on HBASE-11551:
-------------------------------

bq. Anyway, writer thread shouldn't exit except the flag 'cacheEnabled' is set to false.
[~zjushch]

This patch makes a change so that instead of the thread exiting, instead we'll fill the logs
w/ ERROR logs.  There is no 'fix' here.  At an extreme, if you talked to the fellow whose
filesystem just overflowed with unnoticed ERROR logs because of some non-self-healing issue
in bucket cache and you asked him if he'd preferred instead that his bucket cache instead
just got stuck, he might say the latter? This is why I ask: "Is this a real issue? Was it
encountered running a test?" Or is it just make-work code reading? I have been working in
this area of late so am interested in anything that has been learned.  Have you run into this
[~zjushch]?  Thanks.

> BucketCache$WriterThread.run() doesn't handle exceptions correctly
> ------------------------------------------------------------------
>
>                 Key: HBASE-11551
>                 URL: https://issues.apache.org/jira/browse/HBASE-11551
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.99.0, 2.0.0
>
>         Attachments: 11551-v1.txt
>
>
> Currently the catch is outside the while loop:
> {code}
>       try {
>         while (cacheEnabled && writerEnabled) {
> ...
>       } catch (Throwable t) {
>         LOG.warn("Failed doing drain", t);
>       }
> {code}
> When exception (e.g. BucketAllocatorException) is thrown, run() method would terminate,
silently.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message