hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11520) Simplify offheap cache config by removing the confusing "hbase.bucketcache.percentage.in.combinedcache"
Date Thu, 17 Jul 2014 20:53:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065522#comment-14065522
] 

Nick Dimiduk commented on HBASE-11520:
--------------------------------------

bq. You ok w/ it?

Yeah, I'm okay with this. You leave things better than when you found them.

> Simplify offheap cache config by removing the confusing "hbase.bucketcache.percentage.in.combinedcache"
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11520
>                 URL: https://issues.apache.org/jira/browse/HBASE-11520
>             Project: HBase
>          Issue Type: Sub-task
>          Components: io
>    Affects Versions: 0.99.0
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.99.0, 2.0.0
>
>         Attachments: 11520.txt, 11520v2.txt, 11520v3.txt, 11520v3.txt
>
>
> Remove "hbase.bucketcache.percentage.in.combinedcache".  It is unnecessary complication
of block cache config.  Let L1 config setup be as it is whether a L2 present or not, just
set hfile.block.cache.size (not hbase.bucketcache.size * (1.0 - hbase.bucketcache.percentage.in.combinedcache)).
 For L2, let hbase.bucketcache.size be the actual size of the bucket cache, not hbase.bucketcache.size
* hbase.bucketcache.percentage.in.combinedcache.
> Attached patch removes the config. and updates docs.  Adds tests to confirm configs are
as expected whether a CombinedBlockCache deploy or a strict L1+L2 deploy.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message