hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11514) Fix findbugs warnings in blockcache
Date Tue, 15 Jul 2014 01:14:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061507#comment-14061507
] 

Hadoop QA commented on HBASE-11514:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12655635/10930v3.txt
  against trunk revision .
  ATTACHMENT ID: 12655635

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.replication.TestPerTableCFReplication

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 	at org.apache.hadoop.hbase.client.TestReplicaWithCluster.testCreateDeleteTable(TestReplicaWithCluster.java:138)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10061//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10061//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10061//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10061//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10061//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10061//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10061//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10061//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10061//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10061//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10061//console

This message is automatically generated.

> Fix findbugs warnings in blockcache
> -----------------------------------
>
>                 Key: HBASE-11514
>                 URL: https://issues.apache.org/jira/browse/HBASE-11514
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.99.0, 2.0.0
>
>         Attachments: 10930.txt, 10930v2.txt, 10930v3.txt
>
>
> Fixing a few findbugs issues around blockcache.  Adding equals when we have compareTo.
 Noticed that hbase.bucketcache.percentage.in.combinedcache is NOT used anywhere though we
doc it as working.   Rather than implement, I'm removing it.  Makes config of cache cleaner
(do the L1 and then do the L2 independent of each other rather than have independent config
and then this odd hbase.bucketcache.percentage.in.combinedcache that spans them).
> Changed the package doc to remove reference to hbase.bucketcache.percentage.in.combinedcache
(did an edit too removing slabcache mentions in package-info).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message