hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11514) Fix findbugs warnings in blockcache
Date Mon, 14 Jul 2014 20:50:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061216#comment-14061216

stack commented on HBASE-11514:

Hang on.  Looks like the below commit broke the hbase.bucketcache.percentage.in.combinedcache

commit 20cac213aff85ee1380aef6d42a1042c2bbe5901
Author: Nick Dimiduk <ndimiduk@apache.org>
Date:   Mon Jun 30 19:18:46 2014 -0700

    HBASE-11372 Remove SlabCache

Let me restore it.

> Fix findbugs warnings in blockcache
> -----------------------------------
>                 Key: HBASE-11514
>                 URL: https://issues.apache.org/jira/browse/HBASE-11514
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>         Attachments: 10930.txt
> Fixing a few findbugs issues around blockcache.  Adding equals when we have compareTo.
 Noticed that hbase.bucketcache.percentage.in.combinedcache is NOT used anywhere though we
doc it as working.   Rather than implement, I'm removing it.  Makes config of cache cleaner
(do the L1 and then do the L2 independent of each other rather than have independent config
and then this odd hbase.bucketcache.percentage.in.combinedcache that spans them).
> Changed the package doc to remove reference to hbase.bucketcache.percentage.in.combinedcache
(did an edit too removing slabcache mentions in package-info).

This message was sent by Atlassian JIRA

View raw message