hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11513) Combine SingleMultiple Queue RpcExecutor into a single class
Date Tue, 15 Jul 2014 00:50:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061486#comment-14061486
] 

Hudson commented on HBASE-11513:
--------------------------------

FAILURE: Integrated in HBase-0.98 #399 (See [https://builds.apache.org/job/HBase-0.98/399/])
HBASE-11513 Combine SingleMultiple Queue RpcExecutor into a single class (Jesse Yates) (apurtell:
rev 19fa2e346ce4386adfbd43516079157436b585d2)
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SingleQueueRpcExecutor.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MultipleQueueRpcExecutor.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/BalancedQueueRpcExecutor.java


> Combine SingleMultiple Queue RpcExecutor into a single class
> ------------------------------------------------------------
>
>                 Key: HBASE-11513
>                 URL: https://issues.apache.org/jira/browse/HBASE-11513
>             Project: HBase
>          Issue Type: Improvement
>          Components: io, regionserver
>    Affects Versions: 0.99.0, 0.98.4, 2.0.0
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>            Priority: Minor
>             Fix For: 0.99.0, 0.98.4, 2.0.0
>
>         Attachments: HBASE-11513-0.98.patch, HBASE-11513.patch, hbase-11513-v0.patch
>
>
> Its a little odd that we use multiple classes, leading to mutliple if-else conditions
for rpc execution when we could just combine them into one. Makes the logic and also puts
the code into one place



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message