hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11511) Write flush events to WAL
Date Tue, 15 Jul 2014 00:44:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061483#comment-14061483
] 

Hadoop QA commented on HBASE-11511:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12655623/hbase-11511_v2.patch
  against trunk revision .
  ATTACHMENT ID: 12655623

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 1 new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +              new java.lang.String[] { "Action", "FlushSeqId", "TableName", "EncodedRegionName",
"StoreFlushes", });
+            desc, sequenceId, false); // no sync. Sync is below where we do not hold the
updates lock
+    long trx = log.appendNoSync(htd, info, key, WALEdit.createFlushWALEdit(info, f), sequenceId,
false, null);

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10060//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10060//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10060//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10060//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10060//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10060//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10060//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10060//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10060//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10060//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10060//console

This message is automatically generated.

> Write flush events to WAL
> -------------------------
>
>                 Key: HBASE-11511
>                 URL: https://issues.apache.org/jira/browse/HBASE-11511
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.99.0, 2.0.0
>
>         Attachments: hbase-11511_v1.patch, hbase-11511_v1.patch, hbase-11511_v2.patch,
hbase-11511_v3.patch
>
>
> We used to write COMPLETE_FLUSH event to WAL until it got removed in 0.96 in issue HBASE-7329.

> For secondary region replicas, it is important to share the data files with the primary
region. So we should reintroduce the flush wal markers so that the secondary region replicas
can pick up the newly flushed files from the WAL and start serving data from those. 
> A design doc which explains the context a bit better can be found in HBASE-11183. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message