hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11499) AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop
Date Mon, 14 Jul 2014 07:15:06 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060394#comment-14060394
] 

Hudson commented on HBASE-11499:
--------------------------------

SUCCESS: Integrated in HBase-TRUNK #5296 (See [https://builds.apache.org/job/HBase-TRUNK/5296/])
HBASE-11499 AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop
(Mike Drob) (stack: rev a6fd48ba12e0f82b3ea937227845a63e5c1f8bf7)
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java


> AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-11499
>                 URL: https://issues.apache.org/jira/browse/HBASE-11499
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>            Priority: Trivial
>              Labels: findbugs
>             Fix For: 2.0.0
>
>         Attachments: HBASE-11499.patch.txt, HBASE-11499.v2.patch.txt
>
>
> The method is building a string using lots of concatenation, including in a loop, which
will be {{O(n^2)}} because a new array will be allocated each time. Would be more efficient
to use a StringBuilder for this.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message