hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11499) AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop
Date Thu, 10 Jul 2014 21:25:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057983#comment-14057983
] 

Mike Drob commented on HBASE-11499:
-----------------------------------

It looks like HadoopQA is applying the patches with -p1 now? Which would mean that the docs
at http://hbase.apache.org/book/submitting.patches.html#submitting.patches.create need to
be updated to not suggest using {{--no-prefix}}. Can somebody verify?

> AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-11499
>                 URL: https://issues.apache.org/jira/browse/HBASE-11499
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: Mike Drob
>            Priority: Trivial
>              Labels: findbugs
>         Attachments: HBASE-11499.patch.txt
>
>
> The method is building a string using lots of concatenation, including in a loop, which
will be {{O(n^2)}} because a new array will be allocated each time. Would be more efficient
to use a StringBuilder for this.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message