hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11480) ClientScanner might not close the HConnection created in construction
Date Tue, 15 Jul 2014 05:42:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061700#comment-14061700
] 

stack commented on HBASE-11480:
-------------------------------

bq.  Is it better to deprecate this construction?

Then this seems like good way to go and undo any uses of this internal constructor too.  Good
stuff.

> ClientScanner might not close the HConnection created in construction
> ---------------------------------------------------------------------
>
>                 Key: HBASE-11480
>                 URL: https://issues.apache.org/jira/browse/HBASE-11480
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, Scanners
>    Affects Versions: 0.96.2, 0.94.20, 0.98.3
>            Reporter: cuijianwei
>            Priority: Trivial
>
> ClientScanner will create HConnection in its construction:
> {code}
>     public ClientScanner(final Configuration conf, final Scan scan,
>         final byte[] tableName) throws IOException {
>       this(conf, scan, tableName, HConnectionManager.getConnection(conf));
>     }
> {code}
> However, this connection won't be closed in ClientScanner.close(). Is it better to deprecate
this construction?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message