hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11463) (findbugs) HE: Class defines equals() and uses Object.hashCode()
Date Thu, 03 Jul 2014 22:00:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051958#comment-14051958
] 

stack commented on HBASE-11463:
-------------------------------

bq. Just a reminder that without adding more tests, it places burden on the developers to
be more vigilant in the future about what changing the equality contract means.

Yes. I suppose it could surprise (looking at the classes, unlikely, but hey.. if it were likely,
it wouldn't be a surprise).  Any chance of adding in simple equals test for the types you've
fixed?

> (findbugs) HE: Class defines equals() and uses Object.hashCode()
> ----------------------------------------------------------------
>
>                 Key: HBASE-11463
>                 URL: https://issues.apache.org/jira/browse/HBASE-11463
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mike Drob
>            Priority: Trivial
>              Labels: findbugs
>         Attachments: HBASE-11463.patch.txt
>
>
> Findbugs warns that several classes define {{equals}} but not {{hashcode}}:
> {noformat}
> HE: Class defines equals() and uses Object.hashCode() (HE_EQUALS_USE_HASHCODE)
> This class overrides equals(Object), but does not override hashCode(), and inherits the
implementation of hashCode() from java.lang.Object (which returns the identity hash code,
an arbitrary value assigned to the object by the VM).  Therefore, the class is very likely
to violate the invariant that equal objects must have equal hashcodes.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message