hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11444) Remove use of reflection for User#getShortName
Date Tue, 08 Jul 2014 22:46:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055624#comment-14055624
] 

Hadoop QA commented on HBASE-11444:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12654659/HBASE-11444.patch
  against trunk revision .
  ATTACHMENT ID: 12654659

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 4 new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 	at org.apache.hadoop.hbase.mapreduce.TestImportExport.testMetaExport(TestImportExport.java:209)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9998//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9998//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9998//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9998//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9998//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9998//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9998//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9998//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9998//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9998//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9998//console

This message is automatically generated.

> Remove use of reflection for User#getShortName
> ----------------------------------------------
>
>                 Key: HBASE-11444
>                 URL: https://issues.apache.org/jira/browse/HBASE-11444
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.98.3
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.99.0, 0.98.4, 2.0.0
>
>         Attachments: HBASE-11444.patch, HBASE-11444.patch, IntegrationTestIngestWithACL.get.svg,
IntegrationTestIngestWithACL.get.svg, IntegrationTestIngestWithACL.put.svg, IntegrationTestIngestWithACL.put.svg
>
>
> The time we spend looking up a user's short name with User#getShortName in hot security
code paths is mostly spent in Class#getMethod, ~70%. This is only ~1% of overall CPU time
but is the bulk of time spent in AccessController#prePut, for example.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message