hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11437) Modify cell tag handling code to treat the length as unsigned
Date Sun, 13 Jul 2014 09:51:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060062#comment-14060062
] 

Hudson commented on HBASE-11437:
--------------------------------

SUCCESS: Integrated in HBase-1.0 #33 (See [https://builds.apache.org/job/HBase-1.0/33/])
HBASE-11437 Modify cell tag handling code to treat the length as unsigned. (Anoop) (anoopsamjohn:
rev 42a7be1032d72791b7df2ea4d987fe35e6c6af19)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
* hbase-common/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
* hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeCell.java
* hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeArrayScanner.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/CopyKeyDataBlockEncoder.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV3.java
* hbase-common/src/test/java/org/apache/hadoop/hbase/io/TestTagCompressionContext.java
* hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestPayloadCarryingRpcController.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileWriterV3.java
* hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestByteRangeWithKVSerialization.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/Cell.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/NoOpDataBlockEncoder.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV3.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/io/TagCompressionContext.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java


> Modify cell tag handling code to treat the length as unsigned
> -------------------------------------------------------------
>
>                 Key: HBASE-11437
>                 URL: https://issues.apache.org/jira/browse/HBASE-11437
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0, 0.98.4, 2.0.0
>
>         Attachments: HBASE-11437.patch, HBASE-11437.patch, HBASE-11437.patch, HBASE-11437_0.98.patch,
HBASE-11437_0.98_V2.patch, HBASE-11437_trunk.patch
>
>
> We store each tag's length and total tags length with 2 bytes in KeyValue buffer, HFiles
etc and we treat these lengths as short through out the code.  So the max length can be Short.MAX_VALUE.
  We can treat these lengths as unsigned and +ve always.  So we can actually treat these lengths
as int and store with 2 bytes so that the max length can reach 65535.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message