hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method "getPeer" of the class ReplicationPeersZKImpl
Date Thu, 24 Jul 2014 23:23:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073829#comment-14073829
] 

Hadoop QA commented on HBASE-11388:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12653824/HBASE_11388_trunk_V1.patch
  against trunk revision .
  ATTACHMENT ID: 12653824

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10182//console

This message is automatically generated.

> The order parameter is wrong when invoking the constructor of the ReplicationPeer In
the method "getPeer" of the class ReplicationPeersZKImpl
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11388
>                 URL: https://issues.apache.org/jira/browse/HBASE-11388
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 0.99.0, 0.98.3
>            Reporter: Qianxi Zhang
>            Assignee: Qianxi Zhang
>            Priority: Minor
>             Fix For: 0.99.0, 0.98.5
>
>         Attachments: HBASE_11388.patch, HBASE_11388_trunk_V1.patch
>
>
> The parameters is "Configurationi", "ClusterKey" and "id" in the constructor of the class
ReplicationPeer. But he order parameter is "Configurationi", "id" and "ClusterKey" when invoking
the constructor of the ReplicationPeer In the method "getPeer" of the class ReplicationPeersZKImpl
> ReplicationPeer#76
> {code}
>   public ReplicationPeer(Configuration conf, String key, String id) throws ReplicationException
{
>     this.conf = conf;
>     this.clusterKey = key;
>     this.id = id;
>     try {
>       this.reloadZkWatcher();
>     } catch (IOException e) {
>       throw new ReplicationException("Error connecting to peer cluster with peerId="
+ id, e);
>     }
>   }
> {code}
> ReplicationPeersZKImpl#498
> {code}
>     ReplicationPeer peer =
>         new ReplicationPeer(peerConf, peerId, ZKUtil.getZooKeeperClusterKey(peerConf));
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message