hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11335) Fix the TABLE_DIR param in TableSnapshotInputFormat
Date Tue, 01 Jul 2014 00:11:29 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048341#comment-14048341
] 

Hudson commented on HBASE-11335:
--------------------------------

ABORTED: Integrated in HBase-TRUNK #5251 (See [https://builds.apache.org/job/HBase-TRUNK/5251/])
HBASE-11335 Fix the TABLE_DIR param in TableSnapshotInputFormat (deepankar) (enis: rev 5af264c5b5d97643abd2142bfde51fe83f967453)
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatImpl.java


> Fix the TABLE_DIR param in TableSnapshotInputFormat
> ---------------------------------------------------
>
>                 Key: HBASE-11335
>                 URL: https://issues.apache.org/jira/browse/HBASE-11335
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce, snapshots
>    Affects Versions: 0.96.2, 0.98.3
>            Reporter: deepankar
>             Fix For: 0.99.0, 0.96.3, 0.98.4
>
>         Attachments: HBASE_11335-0.96-v1.patch, HBASE_11335-trunk-v1.patch
>
>
> In class *TableSnapshotInputFormat* or *TableSnapshotInputFormatImpl*
> in the function 
> {code}
> public static void setInput(Job job, String snapshotName, Path restoreDir) throws IOException
{
> {code}
> we are setting restoreDir (temporary root) to tableDir
> {code}
> conf.set(TABLE_DIR_KEY, restoreDir.toString());
> {code}
> The above parameter is used to get the InputSplits, especially for 
> calculating favorable hosts in the function
> {code}
> Path tableDir = new Path(conf.get(TABLE_DIR_KEY));
> List<String> hosts = getBestLocations(conf,
>           HRegion.computeHDFSBlocksDistribution(conf, htd, hri, tableDir));
> {code}
> This will lead to returning a empty *HDFSBlocksDistribution*, as there is 
> will be no directory with name as the region name from hri in the restored
> root directory, which will lead to scheduling of non local tasks.
> The change is simple in the sense, is to call the {code}FSUtils.getTableDir(rootDir,
tableDesc.getTableName()) {code}
> in the getSplits function
> more discussion in the comments below 
> https://issues.apache.org/jira/browse/HBASE-8369?focusedCommentId=14012085&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14012085



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message