Return-Path: 
 <issues-return-150760-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 1A42111E51
	for <apmail-hbase-issues-archive@www.apache.org>;
 Wed, 25 Jun 2014 02:04:26 +0000 (UTC)
Received: (qmail 45613 invoked by uid 500); 25 Jun 2014 02:04:25 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 45572 invoked by uid 500); 25 Jun 2014 02:04:25 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 45555 invoked by uid 99); 25 Jun 2014 02:04:25 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jun 2014 02:04:25 +0000
Date: Wed, 25 Jun 2014 02:04:25 +0000 (UTC)
From: "Qiang Tian (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12723324.1403603659419.42594.1403661865701@arcas>
In-Reply-To: <JIRA.12723324.1403603659419@arcas>
References: <JIRA.12723324.1403603659419@arcas>
Subject: [jira] [Commented] (HBASE-11406) ExportSnapshot#run better catch
 Throwable for ExportSnapshot#runCopyJob
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-11406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042958#comment-14042958 ] 

Qiang Tian commented on HBASE-11406:
------------------------------------

Hi [~apurtell], 
yes...
from dev's perspective it looks strange, but from user's perspective, anything is possible..:-)


> ExportSnapshot#run better catch Throwable for ExportSnapshot#runCopyJob
> -----------------------------------------------------------------------
>
>                 Key: HBASE-11406
>                 URL: https://issues.apache.org/jira/browse/HBASE-11406
>             Project: HBase
>          Issue Type: Improvement
>          Components: snapshots
>            Reporter: Qiang Tian
>            Assignee: Qiang Tian
>            Priority: Trivial
>         Attachments: hbase11406-master.patch
>
>
> ExportSnapshot#run better catch Throwable for ExportSnapshot#runCopyJob since runCopyJob involves hadoop and mapreduce. other errors could be thrown, catching them like below at first place is helpful for error handling and problem identification.
> 14/06/24 18:39:30 ERROR snapshot.ExportSnapshot: Snapshot export failed
> java.lang.NoSuchMethodError: org/apache/hadoop/mapred/JobTracker.getAddress(Lorg/apache/hadoop/conf/Configuration;)Ljava/net/InetSocketAddress;
>         at org.apache.hadoop.mapred.JobTrackerClientProtocolProvider.create(JobTrackerClientProtocolProvider.java:44)
>         at org.apache.hadoop.mapreduce.Cluster.initialize(Cluster.java:95)
>         at org.apache.hadoop.mapreduce.Cluster.<init>(Cluster.java:82)
>         at org.apache.hadoop.mapreduce.Cluster.<init>(Cluster.java:75)
>         at org.apache.hadoop.hbase.mapreduce.JobUtil.getStagingDir(JobUtil.java:54)
>         at org.apache.hadoop.hbase.snapshot.ExportSnapshot.getInputFolderPath(ExportSnapshot.java:541)
>         at org.apache.hadoop.hbase.snapshot.ExportSnapshot.runCopyJob(ExportSnapshot.java:609)
>         at org.apache.hadoop.hbase.snapshot.ExportSnapshot.run(ExportSnapshot.java:776)
>         at org.apache.hadoop.hbase.backup.BackupCopier.copy(BackupCopier.java:248)
>         at org.apache.hadoop.hbase.backup.BackupHandler.snapshotCopy(BackupHandler.java:559)
>         at org.apache.hadoop.hbase.backup.BackupHandler.call(BackupHandler.java:141)
>         at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:314)
>         at java.util.concurrent.FutureTask.run(FutureTask.java:149)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:897)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:919)
>         at java.lang.Thread.run(Thread.java:738)



--
This message was sent by Atlassian JIRA
(v6.2#6252)