Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 26E2C11D55 for ; Sat, 21 Jun 2014 02:32:25 +0000 (UTC) Received: (qmail 26307 invoked by uid 500); 21 Jun 2014 02:32:24 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 26251 invoked by uid 500); 21 Jun 2014 02:32:24 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 26236 invoked by uid 99); 21 Jun 2014 02:32:24 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 Jun 2014 02:32:24 +0000 Date: Sat, 21 Jun 2014 02:32:24 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method "getPeer" of the class ReplicationPeersZKImpl MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039653#comment-14039653 ] Ted Yu commented on HBASE-11388: -------------------------------- J-D is familiar with this code. That's why I asked him to take a look. > The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method "getPeer" of the class ReplicationPeersZKImpl > --------------------------------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-11388 > URL: https://issues.apache.org/jira/browse/HBASE-11388 > Project: HBase > Issue Type: Bug > Components: Replication > Affects Versions: 0.99.0, 0.98.3 > Reporter: Qianxi Zhang > Assignee: Qianxi Zhang > Priority: Minor > Fix For: 0.99.0 > > Attachments: HBASE_11388.patch > > > The parameters is "Configurationi", "ClusterKey" and "id" in the constructor of the class ReplicationPeer. But he order parameter is "Configurationi", "id" and "ClusterKey" when invoking the constructor of the ReplicationPeer In the method "getPeer" of the class ReplicationPeersZKImpl > ReplicationPeer#76 > {code} > public ReplicationPeer(Configuration conf, String key, String id) throws ReplicationException { > this.conf = conf; > this.clusterKey = key; > this.id = id; > try { > this.reloadZkWatcher(); > } catch (IOException e) { > throw new ReplicationException("Error connecting to peer cluster with peerId=" + id, e); > } > } > {code} > ReplicationPeersZKImpl#498 > {code} > ReplicationPeer peer = > new ReplicationPeer(peerConf, peerId, ZKUtil.getZooKeeperClusterKey(peerConf)); > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)