Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 18 Jun 2014 18:18:27 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12721843.1403071128270.1518.1403115507863@arcas>
In-Reply-To: <JIRA.12721843.1403071128270@arcas>
References: <JIRA.12721843.1403071128270@arcas>
Subject: [jira] [Commented] (HBASE-11373) hbase-protocol compile failed for
 name conflict of RegionTransition
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036078#comment-14036078 ] 

Hadoop QA commented on HBASE-11373:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12651182/hbase-11373.patch
  against trunk revision .
  ATTACHMENT ID: 12651182

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +       * <code>rpc ReportRegionStateTransition(.ReportRegionStateTransitionRequest) returns (.ReportRegionStateTransitionResponse);</code>
+     * <code>rpc ReportRegionStateTransition(.ReportRegionStateTransitionRequest) returns (.ReportRegionStateTransitionResponse);</code>

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestAssignmentManager

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9789//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9789//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9789//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9789//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9789//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9789//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9789//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9789//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9789//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9789//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9789//console

This message is automatically generated.

> hbase-protocol compile failed for name conflict of RegionTransition
> -------------------------------------------------------------------
>
>                 Key: HBASE-11373
>                 URL: https://issues.apache.org/jira/browse/HBASE-11373
>             Project: HBase
>          Issue Type: Bug
>          Components: Protobufs
>            Reporter: Liu Shaohui
>            Assignee: Jimmy Xiang
>            Priority: Minor
>         Attachments: hbase-11373.patch
>
>
> The compile of hbase-protocol failed for there are two message named RegionTransition in ZooKeeper.proto and RegionServerStatus.proto
> {quote}
> $mvn clean package -Pcompile-protobuf  -X
> ....
> \[DEBUG\] RegionServerStatus.proto:81:9: "RegionTransition" is already defined in file "ZooKeeper.proto".
> \[DEBUG\] RegionServerStatus.proto:114:12: "RegionTransition" seems to be defined in "ZooKeeper.proto", which is not imported by "RegionServerStatus.proto".  To use it here, please add the necessary import.
> \[ERROR\] protoc compiler error
> {quote} 
> Through It will be ok if we compile the the ZooKeeper.proto and RegionServerStatus.proto seperately. it is not very convenient.
> The new RegionTransition is RegionServerStatus.proto and introduced in HBASE-11059.
> [~jxiang]
> What's your suggestion about this issue? 


--
This message was sent by Atlassian JIRA
(v6.2#6252)