Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5D203109B7 for ; Mon, 23 Jun 2014 15:49:25 +0000 (UTC) Received: (qmail 26934 invoked by uid 500); 23 Jun 2014 15:49:25 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 26889 invoked by uid 500); 23 Jun 2014 15:49:25 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 26875 invoked by uid 99); 23 Jun 2014 15:49:25 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jun 2014 15:49:25 +0000 Date: Mon, 23 Jun 2014 15:49:25 +0000 (UTC) From: "Dave Latham (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-11360) SnapshotFileCache refresh logic based on modified directory time might be insufficient MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040870#comment-14040870 ] Dave Latham commented on HBASE-11360: ------------------------------------- We're going to run it in our own build locally, so it doesn't make a great difference to us which version it lands in, just that it does make it upstream. > SnapshotFileCache refresh logic based on modified directory time might be insufficient > -------------------------------------------------------------------------------------- > > Key: HBASE-11360 > URL: https://issues.apache.org/jira/browse/HBASE-11360 > Project: HBase > Issue Type: Bug > Affects Versions: 0.94.19 > Reporter: churro morales > Fix For: 0.99.0, 0.94.21, 0.98.4 > > Attachments: HBASE-11360-0.94.patch > > > Right now we decide whether to refresh the cache based on the lastModified timestamp of all the snapshots and those "running" snapshots which is located in the /hbase/.hbase-snapshot/.tmp/ directory > We ran a ExportSnapshot job which takes around 7 minutes between creating the directory and copying all the files. > Thus the modified time for the > /hbase/.hbase-snapshot/.tmp directory was 7 minutes earlier than the modified time of the > /hbase/.hbase-snapshot/.tmp/ directory > Thus the cache refresh happens and doesn't pick up all the files but thinks its up to date as the modified time of the .tmp directory never changes. > This is a bug as when the export job starts the cache never contains the files for the "running" snapshot and will fail. -- This message was sent by Atlassian JIRA (v6.2#6252)