Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 17 Jun 2014 05:57:02 +0000 (UTC)
From: "Anoop Sam John (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12721281.1402819695078.143895.1402984622138@arcas>
In-Reply-To: <JIRA.12721281.1402819695078@arcas>
References: <JIRA.12721281.1402819695078@arcas>
Subject: [jira] [Commented] (HBASE-11354)
 HConnectionImplementation#DelayedClosing does not start
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-11354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033461#comment-14033461 ] 

Anoop Sam John commented on HBASE-11354:
----------------------------------------

Ping [~nkeywal].  You know abt this boss?

Also in DelayedClosing#chore(),  I can see
{code}
}
          closeMasterProtocol(hci.masterServiceState);
          closeMasterProtocol(hci.masterServiceState);
{code}
Why called 2 times?


> HConnectionImplementation#DelayedClosing does not start
> -------------------------------------------------------
>
>                 Key: HBASE-11354
>                 URL: https://issues.apache.org/jira/browse/HBASE-11354
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.99.0, 0.98.3
>            Reporter: Qianxi Zhang
>            Assignee: Qianxi Zhang
>            Priority: Minor
>         Attachments: HBASE_11354.patch
>
>
> The method "createAndStart" in class DelayedClosing only creates a instance, but forgets to start it. So thread delayedClosing is not running all the time.
> ConnectionManager#1623
> {code}
>       static DelayedClosing createAndStart(HConnectionImplementation hci){
>         Stoppable stoppable = new Stoppable() {
>               private volatile boolean isStopped = false;
>               @Override public void stop(String why) { isStopped = true;}
>               @Override public boolean isStopped() {return isStopped;}
>             };
>         return new DelayedClosing(hci, stoppable);
>       }
> {code}


--
This message was sent by Atlassian JIRA
(v6.2#6252)