Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 11 Jun 2014 03:05:02 +0000 (UTC)
From: "Jean-Marc Spaggiari (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12720239.1402356257052.106768.1402455902086@arcas>
In-Reply-To: <JIRA.12720239.1402356257052@arcas>
References: <JIRA.12720239.1402356257052@arcas>
Subject: [jira] [Commented] (HBASE-11313) RpcClient should allow Reusable
 pool option.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-11313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027358#comment-14027358 ] 

Jean-Marc Spaggiari commented on HBASE-11313:
---------------------------------------------

This is used in the client side. So I'm not sure we can say that no-one when to use reusable anymore. However, I'm also not sure about the benefits of reusable vs RoundRobin. I think it doesn't hurt to have it available if someone want to use it. If we really prefer to not make it available, then yes we should remove it from the pool types.

Reusable was initially used in HTablePool which is now deprecated. So we can see it as a left over, but I still think we might be good to keep it.

> RpcClient should allow Reusable pool option.
> --------------------------------------------
>
>                 Key: HBASE-11313
>                 URL: https://issues.apache.org/jira/browse/HBASE-11313
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.99.0, 0.98.3
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>            Priority: Minor
>         Attachments: HBASE-11313-v0-trunk.patch
>
>
> RpcClient.getPoolType check the pool choice against ThreadLocal and RoundRobin. However, we have a 3rd pooltype already in, Reusable. We should allow in this getPoolType check.


--
This message was sent by Atlassian JIRA
(v6.2#6252)