Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EE07E11F3B for ; Mon, 9 Jun 2014 17:47:02 +0000 (UTC) Received: (qmail 77199 invoked by uid 500); 9 Jun 2014 17:47:02 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 77154 invoked by uid 500); 9 Jun 2014 17:47:02 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 77140 invoked by uid 99); 9 Jun 2014 17:47:02 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Jun 2014 17:47:02 +0000 Date: Mon, 9 Jun 2014 17:47:02 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-11310) Delete constructor accepting another Delete should copy the attributes also MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025430#comment-14025430 ] Andrew Purtell commented on HBASE-11310: ---------------------------------------- bq. I checked Append, Increment, Scan and Get. That is only part of the client API. bq. Get does not have a copy constructor. Then I advocate adding one. What do you think [~ndimiduk]? > Delete constructor accepting another Delete should copy the attributes also > --------------------------------------------------------------------------- > > Key: HBASE-11310 > URL: https://issues.apache.org/jira/browse/HBASE-11310 > Project: HBase > Issue Type: Bug > Components: mapreduce > Affects Versions: 0.98.3 > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0, 0.98.4 > > Attachments: HBASE-11310.patch > > > The constructor in Delete > {code} > public Delete(final Delete d) { > this.row = d.getRow(); > this.ts = d.getTimeStamp(); > this.familyMap.putAll(d.getFamilyCellMap()); > this.durability = d.durability; > } > {code} > should copy the attributes also. Similar bug was raised for Put also. I remember because I found while debugging an MR issue. Now while checking another MR issue found for delete it has not been done. -- This message was sent by Atlassian JIRA (v6.2#6252)