Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 28FF710C00 for ; Fri, 13 Jun 2014 08:00:19 +0000 (UTC) Received: (qmail 22785 invoked by uid 500); 13 Jun 2014 08:00:18 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 22748 invoked by uid 500); 13 Jun 2014 08:00:18 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 22733 invoked by uid 99); 13 Jun 2014 08:00:18 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jun 2014 08:00:18 +0000 Date: Fri, 13 Jun 2014 08:00:18 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-11094) Distributed log replay is incompatible for rolling restarts MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14030360#comment-14030360 ] Hudson commented on HBASE-11094: -------------------------------- FAILURE: Integrated in HBase-TRUNK #5200 (See [https://builds.apache.org/job/HBase-TRUNK/5200/]) HBase-11094: Distributed log replay is incompatible for rolling restarts (jeffreyz: rev 55cecc9679ca04796450d75e72cfc89e1f3b4970) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java * hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFileSystem.java * hbase-server/src/main/java/org/apache/hadoop/hbase/SplitLogTask.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java * hbase-protocol/src/main/protobuf/Admin.proto * hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java * hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogMethods.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/TestSerialization.java * hbase-protocol/src/main/protobuf/ZooKeeper.proto * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/HLogSplitterHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitLogWorker.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/MetaServerShutdownHandler.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerNoMaster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java > Distributed log replay is incompatible for rolling restarts > ----------------------------------------------------------- > > Key: HBASE-11094 > URL: https://issues.apache.org/jira/browse/HBASE-11094 > Project: HBase > Issue Type: Sub-task > Reporter: Enis Soztutar > Assignee: Jeffrey Zhong > Priority: Blocker > Fix For: 0.99.0 > > Attachments: hbase-11094-v2.patch, hbase-11094-v3.patch, hbase-11094-v4.patch, hbase-11094-v5.1.patch, hbase-11094-v5.patch, hbase-11094.patch > > > 0.99.0 comes with dist log replay by default (HBASE-10888). However, reading the code and discussing this with Jeffrey, we realized that the dist log replay code is not compatible with rolling upgrades from 0.98.0 and 1.0.0. > The issue is that, the region server looks at it own configuration to decide whether the region should be opened in replay mode or not. The open region RPC does not contain that info. So if dist log replay is enabled on master, the master will assign the region and schedule replay tasks. If the region is opened in a RS that does not have this conf enabled, then it will happily open the region in normal mode (not replay mode) causing possible (transient) data loss. -- This message was sent by Atlassian JIRA (v6.2#6252)