Return-Path: 
 <issues-return-150893-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A91FE115FC
	for <apmail-hbase-issues-archive@www.apache.org>;
 Thu, 26 Jun 2014 06:08:24 +0000 (UTC)
Received: (qmail 8388 invoked by uid 500); 26 Jun 2014 06:08:24 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 8335 invoked by uid 500); 26 Jun 2014 06:08:24 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 8322 invoked by uid 99); 26 Jun 2014 06:08:24 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jun 2014 06:08:24 +0000
Date: Thu, 26 Jun 2014 06:08:24 +0000 (UTC)
From: "Matteo Bertozzi (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12533537.1322782612797.52036.1403762904386@arcas>
In-Reply-To: <JIRA.12533537.1322782612797@arcas>
References: <JIRA.12533537.1322782612797@arcas>
Subject: [jira] [Commented] (HBASE-4931) CopyTable instructions could be
 improved.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14044374#comment-14044374 ] 

Matteo Bertozzi commented on HBASE-4931:
----------------------------------------

The rs.impl and rs.class do not default to ReplicationXYZ. The command line in this jira is just an example of what you can do. and as far as I know we don't have those ReplicationXYZ classes in the codebase.

the <command>export</command> referenced in the Import, should be with the first letter uppercase.

At the end "For performance consider the following general options scanner.caching=100 speculative.execution=false"
speculative execution should be always off and not for performance reason but to avoid to write data twice which may produce the wrong result.
For the caching maybe say something like >= 100, or some explanation like an higher value uses more memory but does less round trip to the server which may improve performance (something like that)

then there is another reference to the ReplicationRegionInterface and ReplicationRegionServer which I'm not able to find anywhere in our code base

> CopyTable instructions could be improved.
> -----------------------------------------
>
>                 Key: HBASE-4931
>                 URL: https://issues.apache.org/jira/browse/HBASE-4931
>             Project: HBase
>          Issue Type: Bug
>          Components: documentation, mapreduce
>    Affects Versions: 0.90.4, 0.92.0
>            Reporter: Jonathan Hsieh
>            Assignee: Misty Stanley-Jones
>         Attachments: HBASE-4931.patch
>
>
> The book and the usage instructions could be improved to include more details, things caveats and to better explain usage.
> One example in particular, could be updated to refer to ReplicationRegionInterface and ReplicationRegionServer in thier current locations (o.a.h.h.client.replication and o.a.h.h.replication.regionserver), and better explain why one would use particular arguments.
> {code}
> $ bin/hbase org.apache.hadoop.hbase.mapreduce.CopyTable
> --rs.class=org.apache.hadoop.hbase.ipc.ReplicationRegionInterface
> --rs.impl=org.apache.hadoop.hbase.regionserver.replication.ReplicationRegionServer
> --starttime=1265875194289 --endtime=1265878794289
> --peer.adr=server1,server2,server3:2181:/hbase TestTable
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)