hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11434) [AccessController] Disallow inbound cells with reserved tags
Date Sun, 29 Jun 2014 02:00:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047032#comment-14047032
] 

Anoop Sam John commented on HBASE-11434:
----------------------------------------

{code}
+    // Superusers are allowed to store cells unconditionally
+    if (!(superusers.contains(user.getShortName()))) {
+      return;
+    }
{code}

Should be superusers.containc()  check not the ! check right Andy?

> [AccessController] Disallow inbound cells with reserved tags
> ------------------------------------------------------------
>
>                 Key: HBASE-11434
>                 URL: https://issues.apache.org/jira/browse/HBASE-11434
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.99.0, 0.98.4
>
>         Attachments: HBASE-11434.patch
>
>
> The AccessController allows users to store cells with ACL tags encoded by the client.
This isn't a security issue currently, because in order to store the cell the user must have
a relevant WRITE grant, and the user is allowed to specify whatever ACL for the cell they'd
like. However it could become a correctness problem in the future, if we introduce format
sanity checking or the like, so let's disallow inbound mutations containing cells with reserved
tags like the VisibilityController does. 
> The check is skipped if the active user is a superuser. First, superusers are allowed
to do anything. Second, replication (as superuser) must be able to store incoming cells with
ACL tags. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message