hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11388) The order parameter is wrong when invoking the constructor of the ReplicationPeer In the method "getPeer" of the class ReplicationPeersZKImpl
Date Sat, 21 Jun 2014 02:32:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039653#comment-14039653
] 

Ted Yu commented on HBASE-11388:
--------------------------------

J-D is familiar with this code.
That's why I asked him to take a look.

> The order parameter is wrong when invoking the constructor of the ReplicationPeer In
the method "getPeer" of the class ReplicationPeersZKImpl
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11388
>                 URL: https://issues.apache.org/jira/browse/HBASE-11388
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 0.99.0, 0.98.3
>            Reporter: Qianxi Zhang
>            Assignee: Qianxi Zhang
>            Priority: Minor
>             Fix For: 0.99.0
>
>         Attachments: HBASE_11388.patch
>
>
> The parameters is "Configurationi", "ClusterKey" and "id" in the constructor of the class
ReplicationPeer. But he order parameter is "Configurationi", "id" and "ClusterKey" when invoking
the constructor of the ReplicationPeer In the method "getPeer" of the class ReplicationPeersZKImpl
> ReplicationPeer#76
> {code}
>   public ReplicationPeer(Configuration conf, String key, String id) throws ReplicationException
{
>     this.conf = conf;
>     this.clusterKey = key;
>     this.id = id;
>     try {
>       this.reloadZkWatcher();
>     } catch (IOException e) {
>       throw new ReplicationException("Error connecting to peer cluster with peerId="
+ id, e);
>     }
>   }
> {code}
> ReplicationPeersZKImpl#498
> {code}
>     ReplicationPeer peer =
>         new ReplicationPeer(peerConf, peerId, ZKUtil.getZooKeeperClusterKey(peerConf));
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message