hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11363) Access checks in preCompact and preCompactSelection are out of sync
Date Fri, 20 Jun 2014 16:55:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039023#comment-14039023
] 

Andrew Purtell commented on HBASE-11363:
----------------------------------------

Checking in both preCompactScannerOpen and preCompact would be redundant. I think an access
check for the ADMIN bit for compaction is easier to understand if in preCompact, but have
no strong opinion about moving it with a comment. So is the patch on this issue good enough
for now [~anoop.hbase], or would you like to see more? 

> Access checks in preCompact and preCompactSelection are out of sync
> -------------------------------------------------------------------
>
>                 Key: HBASE-11363
>                 URL: https://issues.apache.org/jira/browse/HBASE-11363
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.3
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.99.0, 0.98.4
>
>         Attachments: HBASE-11363.patch
>
>
> As discussed on HBASE-6192, it looks like someone cut and pasted the access check from
preCompact into preCompactSelection at one time and, later, another change was made that relaxed
permissions for compaction requests from ADMIN to ADMIN|CREATE.
> We do not need an access check in preCompactSelection since a request to compact is already
mediated by preCompact.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message