hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicolas Liochon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11354) HConnectionImplementation#DelayedClosing does not start
Date Tue, 17 Jun 2014 12:46:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033739#comment-14033739
] 

Nicolas Liochon commented on HBASE-11354:
-----------------------------------------

bq. Do clients keep up a connection to zk? I thought you'd fixed it so we just do the lookup
and then let the zk connection go @nkeywal?
Yeah, they should not. They have one at the beginning to get the address of the meta/root
server, then they should close it once the keept alive is reached. But may be there is a bug
or regression here, I haven't checked for a while...

> HConnectionImplementation#DelayedClosing does not start
> -------------------------------------------------------
>
>                 Key: HBASE-11354
>                 URL: https://issues.apache.org/jira/browse/HBASE-11354
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.99.0, 0.98.3
>            Reporter: Qianxi Zhang
>            Assignee: Qianxi Zhang
>            Priority: Minor
>         Attachments: HBASE_11354.patch
>
>
> The method "createAndStart" in class DelayedClosing only creates a instance, but forgets
to start it. So thread delayedClosing is not running all the time.
> ConnectionManager#1623
> {code}
>       static DelayedClosing createAndStart(HConnectionImplementation hci){
>         Stoppable stoppable = new Stoppable() {
>               private volatile boolean isStopped = false;
>               @Override public void stop(String why) { isStopped = true;}
>               @Override public boolean isStopped() {return isStopped;}
>             };
>         return new DelayedClosing(hci, stoppable);
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message