hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Marc Spaggiari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11313) RpcClient should allow Reusable pool option.
Date Wed, 11 Jun 2014 03:05:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027358#comment-14027358
] 

Jean-Marc Spaggiari commented on HBASE-11313:
---------------------------------------------

This is used in the client side. So I'm not sure we can say that no-one when to use reusable
anymore. However, I'm also not sure about the benefits of reusable vs RoundRobin. I think
it doesn't hurt to have it available if someone want to use it. If we really prefer to not
make it available, then yes we should remove it from the pool types.

Reusable was initially used in HTablePool which is now deprecated. So we can see it as a left
over, but I still think we might be good to keep it.

> RpcClient should allow Reusable pool option.
> --------------------------------------------
>
>                 Key: HBASE-11313
>                 URL: https://issues.apache.org/jira/browse/HBASE-11313
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.99.0, 0.98.3
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>            Priority: Minor
>         Attachments: HBASE-11313-v0-trunk.patch
>
>
> RpcClient.getPoolType check the pool choice against ThreadLocal and RoundRobin. However,
we have a 3rd pooltype already in, Reusable. We should allow in this getPoolType check.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message