hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicolas Liochon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11297) Remove some synchros in the rpcServer responder
Date Wed, 04 Jun 2014 17:59:03 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017936#comment-14017936

Nicolas Liochon commented on HBASE-11297:

The real changes are only on the doRespond path.
There are some changes in purge, but the behavior should not change there: the documentation
was saying that were discarding the calls, but the implementation was closing the connection.
It's not really safe to do something different anyway: imagine a half-replied call, you can't
discard it.

for the doRespond, instead of locking when we wanted to add a call to the list, we lock only
if we want to write on the channel. We also to a tryLock to return immediately, so the handler
does not wait.

The test are still running here (I've done multiple versions, the previous versions were ok,
but...). I haven't yet ran the perf tests. It targets the scenario with multiple clients on
the same connection. It's more or less a first step for having more Responders (depending
on the test results). I will do another deep review, but I wanted to show what I was working

> Remove some synchros in the rpcServer responder
> -----------------------------------------------
>                 Key: HBASE-11297
>                 URL: https://issues.apache.org/jira/browse/HBASE-11297
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.99.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 0.99.0
>         Attachments: 11297.v1.patch
> This is on top of another patch that I'm going to put into another jira.

This message was sent by Atlassian JIRA

View raw message