hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11274) More general single-row Condition Mutation
Date Tue, 24 Jun 2014 06:38:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041769#comment-14041769
] 

Hadoop QA commented on HBASE-11274:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12652126/HBASE-11274-trunk-v2.diff
  against trunk revision .
  ATTACHMENT ID: 12652126

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 3 warning messages.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 5 new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +      return rpcCallerFactory.<Boolean> newCaller().callWithRetries(callable, this.operationTimeout);
+  public SingleColumnValueCondition(final byte[] row, final byte[] family, final byte[] qualifier,
final byte[] value) {
+    SingleColumnValueCondition condition = new SingleColumnValueCondition(row, family, qualifier,
value);
+    SingleColumnValueCondition condition = new SingleColumnValueCondition(row, family, qualifier,
CompareOp.GREATER, value);
+    SingleColumnValueCondition condition = new SingleColumnValueCondition(row, family, qualifier,
CompareOp.LESS, value);
+      "dition\022\013\n\003row\030\001 \001(\014\022\016\n\006family\030\002 \001(\014\022\021\n\tq"
+
+              new java.lang.String[] { "Row", "Family", "Qualifier", "CompareType", "Comparator",
"Name", "SerializedCondition", });
+          result = ((RegionObserver) env.getInstance()).preCheckAndMutateAfterRowLock(ctx,
condition,
+    AuthResult authResult = permissionGranted(OpType.CHECK_AND_MUTATE, user, env, condition.getFamilyMap(),
+    conditions.addCondition(new SingleColumnValueCondition(ROW, FAMILY, QUALIFIER, Bytes.toBytes("value1")));

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9834//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9834//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9834//console

This message is automatically generated.

> More general single-row Condition Mutation
> ------------------------------------------
>
>                 Key: HBASE-11274
>                 URL: https://issues.apache.org/jira/browse/HBASE-11274
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>         Attachments: HBASE-11274-trunk-v1.diff, HBASE-11274-trunk-v2.diff
>
>
> Currently, the checkAndDelete and checkAndPut interface  only support atomic mutation
with single condition. But in actual apps, we need more general condition-mutation that support
multi conditions and logical expression with those conditions.
> For example, to support the following sql
> {quote}
>   insert row  where (column A == 'X' and column B == 'Y') or (column C == 'z')
> {quote}
> Suggestions are welcomed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message