hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11094) Distributed log replay is incompatible for rolling restarts
Date Thu, 12 Jun 2014 02:22:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028749#comment-14028749
] 

Enis Soztutar commented on HBASE-11094:
---------------------------------------

>From my understanding of the patch, MasterFS has a volatile replay mode that can only
change once all existing split log tasks are drained. Once that happens, all new tasks are
created with this new mode. 

- Do we still need the changes in open Region RPC? Can we use the region in zk under replaying
nodes be the canonical state? 
- Is this relevant? 
{code}
+++ hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
+      cluster.startRegionServer();
{code}

- Is this relevant? 
{code}
-  private static final int slaves = 3; // also used for testing HTable pool size
+  private static final int slaves = 5; // also used for testing HTable pool size
{code}

- Wrong log name: 
{code}
+  public void testGetPreviousRecoveryMode() throws Exception {
+    LOG.info("testNotAcquireTaskOfDifferentRecoveryMode");
{code}

> Distributed log replay is incompatible for rolling restarts
> -----------------------------------------------------------
>
>                 Key: HBASE-11094
>                 URL: https://issues.apache.org/jira/browse/HBASE-11094
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Jeffrey Zhong
>            Priority: Blocker
>             Fix For: 0.99.0
>
>         Attachments: hbase-11094-v2.patch, hbase-11094-v3.patch, hbase-11094-v4.patch,
hbase-11094-v5.1.patch, hbase-11094-v5.patch, hbase-11094.patch
>
>
> 0.99.0 comes with dist log replay by default (HBASE-10888). However, reading the code
and discussing this with Jeffrey, we realized that the dist log replay code is not compatible
with rolling upgrades from 0.98.0 and 1.0.0.
> The issue is that, the region server looks at it own configuration to decide whether
the region should be opened in replay mode or not. The open region RPC does not contain that
info. So if dist log replay is enabled on master, the master will assign the region and schedule
replay tasks. If the region is opened in a RS that does not have this conf enabled, then it
will happily open the region in normal mode (not replay mode) causing possible (transient)
data loss. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message