hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
Date Sat, 07 Jun 2014 20:10:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020949#comment-14020949
] 

Hadoop QA commented on HBASE-11052:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12648824/HBASE-11052_trunk_v4.patch
  against trunk revision .
  ATTACHMENT ID: 12648824

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9717//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9717//console

This message is automatically generated.

> Sending random data crashes thrift service
> ------------------------------------------
>
>                 Key: HBASE-11052
>                 URL: https://issues.apache.org/jira/browse/HBASE-11052
>             Project: HBase
>          Issue Type: Bug
>          Components: Thrift
>    Affects Versions: 0.98.1, 1.0.0, 0.94.18
>            Reporter: Adrian Muraru
>             Fix For: 1.0.0, 0.94.21, 0.98.4
>
>         Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch,
HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch
>
>
> Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash
with an Out-of-Memory Error when bogus requests are sent.
> This reproduces when a very large request size is sent in the request header, making
the thrift server to allocate a large memory segment leading to OOM.
> LoadBalancer health checks are the first "candidate" for bogus requests
> Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation
is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated
(might not be feasible atm)
> So we need a fix similar to CASSANDRA-475.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message