hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10861) Supporting API in ByteRange
Date Mon, 23 Jun 2014 08:17:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040515#comment-14040515
] 

ramkrishna.s.vasudevan commented on HBASE-10861:
------------------------------------------------

{code}
-    SimpleByteRange that = (SimpleByteRange) thatObject;
+    SimpleMutableByteRange that = (SimpleMutableByteRange) thatObject;
{code}
I think this change is not needed. It should be SimpleByteRange only. The equals in SimpleMutableByteRange
does check with SimpleMutableByteRange.
bq.These you want to be exposed APIs?
These were already part of ByteRange interface and did not add them newly.  So I think for
now we will continue it as it is?
bq.public void clean() throws Exception -> What to do within this?
For DBB allocated byte buffers, we are calling a clean method using reflection. So in case
we use an offheap backed byte range then we may need to provide a way to clean it.  Hence
added it.  But that is now added only for the AbstractPositionedBR.

> Supporting API in ByteRange
> ---------------------------
>
>                 Key: HBASE-10861
>                 URL: https://issues.apache.org/jira/browse/HBASE-10861
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-10861.patch, HBASE-10861_2.patch, HBASE-10861_3.patch, HBASE-10861_4.patch
>
>
> We would need APIs that would 
> setLimit(int limit)
> getLimt()
> asReadOnly()
> These APIs would help in implementations that have Buffers offheap (for now BRs backed
by DBB).
> If anything more is needed could be added when needed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message