hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10810) LoadTestTool should share the connection and connection pool
Date Sat, 28 Jun 2014 06:14:31 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046749#comment-14046749
] 

Hudson commented on HBASE-10810:
--------------------------------

FAILURE: Integrated in HBase-TRUNK #5245 (See [https://builds.apache.org/job/HBase-TRUNK/5245/])
HBASE-10810 LoadTestTool should share the connection and connection pool (enis: rev 25baace0dec1fc4f3b5fb51292c8ec8a6da85ba0)
* hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestTimeBoundedRequestsWithRegionReplicas.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReaderWithACL.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadSequential.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriterWithACL.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriter.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriterBase.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReader.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedAction.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdaterWithACL.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedUpdater.java


> LoadTestTool should share the connection and connection pool
> ------------------------------------------------------------
>
>                 Key: HBASE-10810
>                 URL: https://issues.apache.org/jira/browse/HBASE-10810
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.99.0, hbase-10070
>
>         Attachments: 0038-HBASE-10810-LoadTestTool-should-share-the-connection.patch,
hbase-10810_v1.patch
>
>
> While running the IT test from HBASE-10572, we've noticed that the number of threads
jumps to 4K's when CM actions are going on. 
> Our [~ndimiduk] summarizes the problem quite good: 
> MultiThreadedReader creates this pool for each HTable:
> {code}
>     ThreadPoolExecutor pool = new ThreadPoolExecutor(1, maxThreads, keepAliveTime, TimeUnit.SECONDS,
>         new SynchronousQueue<Runnable>(), Threads.newDaemonThreadFactory("htable"));
> {code}
> This comes from the HTable creation
> {code}  
> public HTable(Configuration conf, final TableName tableName)
> {code}
> As well the javadoc says Recommended.
> This is wrong.
> In this issue we can change the LTT sub classes to use the shared connection object and
initialize their tables using HConnection.getTable() rather than new HTable(). 
> This is relevant to trunk as well, but there since there is only one outstanding RPC
per thread, it is not such a big problem. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message