hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-10092) Move up on to log4j2
Date Mon, 02 Jun 2014 21:37:03 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015927#comment-14015927

Andrew Purtell edited comment on HBASE-10092 at 6/2/14 9:36 PM:

The patch from HBASE-11284

Change summary:\\

- 53 files changed, 497 insertions, 531 deletions

- POM changes: Import log4j2 artifacts only into the compiler classpath. Include the artifacts
that wire log4j2 up to commons-logging and slf4j. Exclude log4j1 except in test scope (required
by Hadoop). Bring slf4j into test scope also (required by Hadoop, ZooKeeper, and Thrift).

- org.apache.log4j.Level is an internal implementation detail of 1.x no longer available.
Remove all uses.

- org.apache.log4j.Appender is also an internal implementation detail of 1.x. One unit test
and a log management utility requires reimplementation or removal. For now offending code
is commented out and marked with TODO

- Replace log4j.properties files with log4j2.xml and log4j2-test.xml files. Not sure if these
are functional yet. May require tweaks if significantly deviating from old behavior. conf/hbase-env.sh
and bin/hbase required minor related changes. Haven't figured out how to do custom log levels
yet like we had in the old log4j.properties files.

was (Author: apurtell):
The patch from HBASE-11284

> Move up on to log4j2
> --------------------
>                 Key: HBASE-10092
>                 URL: https://issues.apache.org/jira/browse/HBASE-10092
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: stack
>         Attachments: 10092.txt, 10092v2.txt, HBASE-10092.patch
> Allows logging with less friction.  See http://logging.apache.org/log4j/2.x/  This rather
radical transition can be done w/ minor change given they have an adapter for apache's logging,
the one we use.  They also have and adapter for slf4j so we likely can remove at least some
of the 4 versions of this module our dependencies make use of.
> I made a start in attached patch but am currently stuck in maven dependency resolve hell
courtesy of our slf4j.  Fixing will take some concentration and a good net connection, an
item I currently lack.  Other TODOs are that will need to fix our little log level setting
jsp page -- will likely have to undo our use of hadoop's tool here -- and the config system
changes a little.
> I will return to this project soon.  Will bring numbers.

This message was sent by Atlassian JIRA

View raw message