Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4BAEB10AE3 for ; Fri, 23 May 2014 06:53:02 +0000 (UTC) Received: (qmail 22680 invoked by uid 500); 23 May 2014 06:53:02 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 22632 invoked by uid 500); 23 May 2014 06:53:02 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 22622 invoked by uid 99); 23 May 2014 06:53:02 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 May 2014 06:53:02 +0000 Date: Fri, 23 May 2014 06:53:02 +0000 (UTC) From: "Lars Hofhansl (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-11234) FastDiffDeltaEncoder#getFirstKeyInBlock returns wrong result MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006927#comment-14006927 ] Lars Hofhansl commented on HBASE-11234: --------------------------------------- It goes without saying that this should be fixed in 0.94 as well, as it is clearly a bug lurking. > FastDiffDeltaEncoder#getFirstKeyInBlock returns wrong result > ------------------------------------------------------------ > > Key: HBASE-11234 > URL: https://issues.apache.org/jira/browse/HBASE-11234 > Project: HBase > Issue Type: Bug > Reporter: chunhui shen > Assignee: chunhui shen > Priority: Critical > Fix For: 0.99.0, 0.96.3, 0.94.20, 0.98.3 > > Attachments: HBASE-11234.patch > > > As Ted found, > With this change: > {noformat} > Index: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestReversibleScanners.java > =================================================================== > --- hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestReversibleScanners.java (revision 1596579) > +++ hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestReversibleScanners.java (working copy) > @@ -51,6 +51,7 @@ > import org.apache.hadoop.hbase.filter.FilterList.Operator; > import org.apache.hadoop.hbase.filter.PageFilter; > import org.apache.hadoop.hbase.filter.SingleColumnValueFilter; > +import org.apache.hadoop.hbase.io.encoding.DataBlockEncoding; > import org.apache.hadoop.hbase.io.hfile.CacheConfig; > import org.apache.hadoop.hbase.io.hfile.HFileContext; > import org.apache.hadoop.hbase.io.hfile.HFileContextBuilder; > @@ -90,6 +91,7 @@ > CacheConfig cacheConf = new CacheConfig(TEST_UTIL.getConfiguration()); > HFileContextBuilder hcBuilder = new HFileContextBuilder(); > hcBuilder.withBlockSize(2 * 1024); > + hcBuilder.withDataBlockEncoding(DataBlockEncoding.FAST_DIFF); > HFileContext hFileContext = hcBuilder.build(); > StoreFile.Writer writer = new StoreFile.WriterBuilder( > TEST_UTIL.getConfiguration(), cacheConf, fs).withOutputDir( > {noformat} > I got: > java.lang.AssertionError: expected: but was: > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:743) > at org.junit.Assert.assertEquals(Assert.java:118) > at org.junit.Assert.assertEquals(Assert.java:144) > at org.apache.hadoop.hbase.regionserver.TestReversibleScanners.seekTestOfReversibleKeyValueScanner(TestReversibleScanners.java:533) > at org.apache.hadoop.hbase.regionserver.TestReversibleScanners.testReversibleStoreFileScanner(TestReversibleScanners.java:108) > After debugging, it seems the method of FastDiffDeltaEncoder#getFirstKeyInBlock become broken. And it will cause hfilescanner#seekBefore returns wrong result. > The solution is simple, see the patch. -- This message was sent by Atlassian JIRA (v6.2#6252)