Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 16 May 2014 11:19:59 +0000 (UTC)
From: "Matteo Bertozzi (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12714645.1400193485863.365766.1400239199651@arcas>
In-Reply-To: <JIRA.12714645.1400193485863@arcas>
References: <JIRA.12714645.1400193485863@arcas>
Subject: [jira] [Commented] (HBASE-11189) Subprocedure should be marked as
 complete upon failure
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-11189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999699#comment-13999699 ] 

Matteo Bertozzi commented on HBASE-11189:
-----------------------------------------

It look ok, but I doubt we have a test verifying what happens when we get a failure. Can you add that? 


> Subprocedure should be marked as complete upon failure
> ------------------------------------------------------
>
>                 Key: HBASE-11189
>                 URL: https://issues.apache.org/jira/browse/HBASE-11189
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.99.0, 0.98.3
>
>         Attachments: 11189-v1.txt
>
>
> ProcedureMember#submitSubprocedure() uses the following check:
> {code}
>       if (!rsub.isComplete()) {
>         LOG.error("Subproc '" + procName + "' is already running. Bailing out");
>         return false;
>       }
> {code}
> If a subprocedure of that name previously ran but failed, its complete field would stay false, leading to early bailout.
> A failed subprocedure should mark itself complete.


--
This message was sent by Atlassian JIRA
(v6.2#6252)