Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 43B8A11480 for ; Wed, 14 May 2014 22:22:44 +0000 (UTC) Received: (qmail 51940 invoked by uid 500); 10 May 2014 22:01:43 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 22422 invoked by uid 500); 10 May 2014 21:59:38 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 81660 invoked by uid 99); 10 May 2014 21:57:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 May 2014 21:57:16 +0000 Date: Sat, 10 May 2014 21:57:16 +0000 (UTC) From: "Enis Soztutar (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-11145) Issue with HLog sync MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-11145: ---------------------------------- Priority: Critical (was: Major) > Issue with HLog sync > -------------------- > > Key: HBASE-11145 > URL: https://issues.apache.org/jira/browse/HBASE-11145 > Project: HBase > Issue Type: Bug > Reporter: Anoop Sam John > Assignee: stack > Priority: Critical > Fix For: 0.99.0 > > > Got the below Exceptions Log in case of a write heavy test > {code} > 2014-05-07 11:29:56,417 ERROR [main.append-pool1-t1] wal.FSHLog$RingBufferEventHandler(1882): UNEXPECTED!!! > java.lang.IllegalStateException: Queue full > at java.util.AbstractQueue.add(Unknown Source) > at org.apache.hadoop.hbase.regionserver.wal.FSHLog$SyncRunner.offer(FSHLog.java:1227) > at org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:1878) > at org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:1) > at com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:133) > at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) > at java.lang.Thread.run(Unknown Source) > 2014-05-07 11:29:56,418 ERROR [main.append-pool1-t1] wal.FSHLog$RingBufferEventHandler(1882): UNEXPECTED!!! > java.lang.ArrayIndexOutOfBoundsException: 5 > at org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:1838) > at org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:1) > at com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:133) > at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) > at java.lang.Thread.run(Unknown Source) > 2014-05-07 11:29:56,419 ERROR [main.append-pool1-t1] wal.FSHLog$RingBufferEventHandler(1882): UNEXPECTED!!! > java.lang.ArrayIndexOutOfBoundsException: 6 > at org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:1838) > at org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:1) > at com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:133) > at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) > at java.lang.Thread.run(Unknown Source) > 2014-05-07 11:29:56,419 ERROR [main.append-pool1-t1] wal.FSHLog$RingBufferEventHandler(1882): UNEXPECTED!!! > java.lang.ArrayIndexOutOfBoundsException: 7 > at org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:1838) > at org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:1) > at com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:133) > at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) > at java.lang.Thread.run(Unknown Source) > {code} > In FSHLog$SyncRunner.offer we do BlockingQueue.add() which throws Exception as it is full. The problem is the below shown catch() we do not do any cleanup. > {code} > this.syncRunners[index].offer(sequence, this.syncFutures, this.syncFuturesCount); > attainSafePoint(sequence); > this.syncFuturesCount = 0; > } catch (Throwable t) { > LOG.error("UNEXPECTED!!!", t); > } > {code} > syncFuturesCount is not getting reset to 0 and so the subsequent onEvent() handling throws ArrayIndexOutOfBoundsException. > I think we should do the below > 1. Handle the Exception and call cleanupOutstandingSyncsOnException() as in other cases of Exception handling > 2. Instead of BlockingQueue.add() use offer() (?) -- This message was sent by Atlassian JIRA (v6.2#6252)