Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 24 May 2014 09:55:01 +0000 (UTC)
From: "ramkrishna.s.vasudevan (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12703550.1395773312511.13791.1400925301566@arcas>
In-Reply-To: <JIRA.12703550.1395773312511@arcas>
References: <JIRA.12703550.1395773312511@arcas>
Subject: [jira] [Commented] (HBASE-10831) IntegrationTestIngestWithACL is
 not setting up LoadTestTool correctly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008090#comment-14008090 ] 

ramkrishna.s.vasudevan commented on HBASE-10831:
------------------------------------------------

I missed a thing in the review, now after this fix
{code}
 if (LoadTestTool.isSecure(getConf())) {
      sb.append(authnFileName);
      sb.append(COLON);
    }
    sb.append(superUser);
    sb.append(COLON);
    sb.append(userNames);
    sb.append(COLON);
    sb.append(Integer.toString(SPECIAL_PERM_CELL_INSERTION_FACTOR));
{code}
WE need to change the code in LoadTestDataGeneratorWithACL 
{code}
super.initialize(args);
    if (args.length != 3) {
      throw new IllegalArgumentException(
          "LoadTestDataGeneratorWithACL can have "
              + "1st arguement which would be super user, the 2nd argument "
              + "would be the user list and the 3rd argument should be the factor representing "
              + "the row keys for which only write ACLs will be added.");
    }
    String temp = args[1];
    // This will be comma separated list of expressions.
    this.userNames = temp.split(COMMA);
    this.specialPermCellInsertionFactor = Integer.parseInt(args[2]);
{code}
We may have to add if condition here to handle the no of args correctly.

> IntegrationTestIngestWithACL is not setting up LoadTestTool correctly
> ---------------------------------------------------------------------
>
>                 Key: HBASE-10831
>                 URL: https://issues.apache.org/jira/browse/HBASE-10831
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.1
>            Reporter: Andrew Purtell
>            Assignee: Vandana Ayyalasomayajula
>             Fix For: 0.99.0, 0.98.3
>
>         Attachments: HBASE-10831_98_v1.patch, HBASE-10831_98_v3.patch, HBASE-10831_98_v4.patch, HBASE-10831_trunk_v2.patch, HBASE-10831_trunk_v3.patch, HBASE-10831_trunk_v4.patch
>
>
> IntegrationTestIngestWithACL is not setting up LoadTestTool correctly.
> {noformat}
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 601.709 sec <<< FAILURE!
> testIngest(org.apache.hadoop.hbase.IntegrationTestIngestWithACL)  Time elapsed: 601.489 sec  <<< FAILURE!
> java.lang.AssertionError: Failed to initialize LoadTestTool expected:<0> but was:<1>
>         at org.junit.Assert.fail(Assert.java:88)
>         at org.junit.Assert.failNotEquals(Assert.java:743)
>         at org.junit.Assert.assertEquals(Assert.java:118)
>         at org.junit.Assert.assertEquals(Assert.java:555)
>         at org.apache.hadoop.hbase.IntegrationTestIngest.initTable(IntegrationTestIngest.java:74)
>         at org.apache.hadoop.hbase.IntegrationTestIngest.setUpCluster(IntegrationTestIngest.java:69)
>         at org.apache.hadoop.hbase.IntegrationTestIngestWithACL.setUpCluster(IntegrationTestIngestWithACL.java:58)
>         at org.apache.hadoop.hbase.IntegrationTestBase.setUp(IntegrationTestBase.java:89)
> {noformat}
> Could be related to HBASE-10675?


--
This message was sent by Atlassian JIRA
(v6.2#6252)