hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11248) KeyOnlyKeyValue#toString() passes wrong offset to keyToString()
Date Tue, 27 May 2014 16:31:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009860#comment-14009860
] 

Ted Yu commented on HBASE-11248:
--------------------------------

lgtm
nit: 
'/vlen=' can be combined with the other constant strings.

> KeyOnlyKeyValue#toString() passes wrong offset to keyToString()
> ---------------------------------------------------------------
>
>                 Key: HBASE-11248
>                 URL: https://issues.apache.org/jira/browse/HBASE-11248
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>         Attachments: HBASE-11248.patch
>
>
> When debugging for HBASE-11234, I found that debugger encountered exception displaying
the string value of KeyOnlyKeyValue.
> It turns out that KeyOnlyKeyValue#toString() passes wrong offset to keyToString(): ROW_OFFSET
should not be used.
> Another bug is that getValueLength() shouldn't be called - it throws IllegalArgumentException.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message