hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11219) HRegionServer#createRegionLoad() should reuse RegionLoad.Builder instance when called in a loop
Date Wed, 21 May 2014 16:28:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004861#comment-14004861
] 

Andrew Purtell commented on HBASE-11219:
----------------------------------------

bq. yet I don't know how big win it is here, as seems these buffers should be collected in
young gen anyway?

You would think but I ran GC manually before dumping the data in the attachment to HBASE-11165.

bq. If the approach is good, same technique can be applied to RegionSpecifier.Builder.

Looks like an improvement, can we do the same for this other builder in one patch on this
issue? Then +1 for trunk and 0.98.

> HRegionServer#createRegionLoad() should reuse RegionLoad.Builder instance when called
in a loop
> -----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11219
>                 URL: https://issues.apache.org/jira/browse/HBASE-11219
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.99.0, 0.98.3
>
>         Attachments: 11219-v1.txt
>
>
> As Andrew showed in the attachment to HBASE-11165, ClusterStatusProtos$RegionLoad$Builder
took 25MB heap space.
> buildServerLoad() calls createRegionLoad() for each region on the region server.
> One instance of ClusterStatusProtos$RegionLoad$Builder can be created outside the loop
and passed to createRegionLoad().
> Thanks Andrew for the finding.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message