hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11210) Consider restoring Filter class back to an interface
Date Sun, 25 May 2014 03:33:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008273#comment-14008273

stack commented on HBASE-11210:

Fellas shouldn't be filing issues when they can't explain why the fix is needed.

Fellas shouldn't be extracting an aspect of a broader story and filing issues on the aspect
only w/o filing out the context in which the issue belongs.

Doing either of the above just makes noise and fills our issue tracking and mailboxes with

> Consider restoring Filter class back to an interface
> ----------------------------------------------------
>                 Key: HBASE-11210
>                 URL: https://issues.apache.org/jira/browse/HBASE-11210
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
> In 0.94, Filter class is an interface.
> From Filter.java in 0.96 :
> {code}
>  * Interface for row and column filters directly applied within the regionserver.
> ...
>  * When implementing your own filters, consider inheriting {@link FilterBase} to help
>  * you reduce boilerplate.
> {code}
> We should consider restoring Filter class back to an interface.
> Lars first brought up this notion:
> https://issues.apache.org/jira/browse/HBASE-6657?focusedCommentId=13456317&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13456317
> This gives users / developers clear suggestion that custom filters should override FilterBase
instead of implementing Filter directly.
> Thanks to Anoop who acknowledged this idea during offline discussion.

This message was sent by Atlassian JIRA

View raw message