hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11210) Consider restoring Filter class back to an interface
Date Sat, 24 May 2014 23:42:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008239#comment-14008239

Lars Hofhansl commented on HBASE-11210:

I forgot why we turned Filter into a class (Gregory explained it, and it made sense, but I
It seems weird to have Filter as a class *and* have a FilterBase class. Proper design would
have it that Filter is an interface and FilterBase is a convenience base implementation of

It's not super important to fix it, but it is certainly an "eyesore".

> Consider restoring Filter class back to an interface
> ----------------------------------------------------
>                 Key: HBASE-11210
>                 URL: https://issues.apache.org/jira/browse/HBASE-11210
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
> In 0.94, Filter class is an interface.
> From Filter.java in 0.96 :
> {code}
>  * Interface for row and column filters directly applied within the regionserver.
> ...
>  * When implementing your own filters, consider inheriting {@link FilterBase} to help
>  * you reduce boilerplate.
> {code}
> We should consider restoring Filter class back to an interface.
> Lars first brought up this notion:
> https://issues.apache.org/jira/browse/HBASE-6657?focusedCommentId=13456317&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13456317
> This gives users / developers clear suggestion that custom filters should override FilterBase
instead of implementing Filter directly.
> Thanks to Anoop who acknowledged this idea during offline discussion.

This message was sent by Atlassian JIRA

View raw message